Update string formatters to new style #552
Conversation
| raise TypeError('Property %s must be convertible to a flow ' | ||
| 'instance; received: %s.' % (self._name, | ||
| value)) | ||
| raise TypeError('Property {0} must be convertible to a flow ' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This looks good to me with some minor style nits. Thanks for doing this @pferate. @nathanielmanistaatgoogle any reservations? |
pferate
force-pushed
the
string_format
branch
3 times, most recently
from
cd198d6
to
57e3f17
Compare
|
@jonparrott: Style changes have been fixed. I also rebased onto @waprin's commit from today, so that all the Travis tests pass. |
|
@pferate great. I'll let @nathanielmanistaatgoogle take a look and merge when he's happy. :) |
| @@ -122,8 +122,8 @@ def open_and_lock(self, timeout, delay): | |||
| CredentialsFileSymbolicLinkError if the file is a symbolic link. | |||
| """ | |||
| if self._locked: | |||
| raise AlreadyLockedException('File %s is already locked' % | |||
| self._filename) | |||
| raise AlreadyLockedException('File {0} is already locked'.format( | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
In your commit message where you say "Leaving |
|
Yes, in 3.2 they introduced the style parameter, which will let you use I don't think it has been backported to python 2, unless it's in a different library or with a different name. |
Changing `%` style string formatters to `.format()`. Leaving `logging` strings in old style for Python 2 compatibility. Resolves: Issue googleapis#541
|
Woohoo. Thank you, @pferate for your contributions that help improve the consistency and health of this project. Thanks, @nathanielmanistaatgoogle for reviewing. :) |
Changing
%style string formatters to.format().Leaving
loggingstrings in old style for Python 2 compatibility.Resolves: Issue #541