Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Djh fixes #80

Closed
wants to merge 2 commits into from
Closed

Djh fixes #80

wants to merge 2 commits into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 5, 2014

@craigcitro I wanted to see what you thought about this before moving too far ahead. It is best digested commit-by-commit, rather than as a big diff.

I know (at the very least) I need to add some tests.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 5, 2014

@craigcitro
Copy link
Contributor

going to look at this now -- but i've gotta clone and look locally, since github can't handle the first commit. ;)

@dhermes
Copy link
Contributor Author

dhermes commented Dec 5, 2014

Oh yes, I should also mention the docs are serving at
http://dhermes.github.io/oauth2client
courtesy of
https://github.com/dhermes/oauth2client/tree/gh-pages

@dhermes
Copy link
Contributor Author

dhermes commented Dec 5, 2014

I just rebased on top of #84 and squashed the hack into a single commit and the test code into a separate single commit.

@dhermes dhermes force-pushed the djh-fixes branch 2 times, most recently from ed27c9a to dd4b5f0 Compare December 5, 2014 19:41
@dhermes
Copy link
Contributor Author

dhermes commented Dec 5, 2014

After ripping out require_refresh in #84 this is now out of sync, but I am going to hold off doing a fixed rebase until #84 is in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants