Skip to content

feat: support uploading local geo data #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 18, 2024
Merged

feat: support uploading local geo data #1036

merged 11 commits into from
Oct 18, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 1, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #308738592 🦕

@arwas11 arwas11 requested review from chelsea-lin and rey-esp October 1, 2024 21:19
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 1, 2024
@chelsea-lin
Copy link
Contributor

The mypy tests failed. Could you please help to fix that? nox -r -s mypy can help to reproduce tests locally.

@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review October 2, 2024 17:58
@chelsea-lin chelsea-lin requested review from a team as code owners October 2, 2024 17:58
chelsea-lin
chelsea-lin requested changes Oct 2, 2024
View reviewed changes
@arwas11 arwas11 requested a review from chelsea-lin October 2, 2024 18:19
chelsea-lin
chelsea-lin approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@arwas11 arwas11 removed the request for review from rey-esp October 7, 2024 15:46
@arwas11 arwas11 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2024
@arwas11 arwas11 requested a review from tswast October 17, 2024 16:42
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2024
@tswast
Copy link
Collaborator

tswast commented Oct 18, 2024

Merging. doctest and Samples test failures appear to be unrelated.

@tswast tswast merged commit 51cdd33 into main Oct 18, 2024
16 of 23 checks passed
@tswast tswast deleted the b308738592-geopandas-upload branch October 18, 2024 17:42
@release-please release-please bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arwas11 @chelsea-lin @tswast @bigframes-bot