Skip to content

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Aug 21, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/440342212.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 21, 2025
@jialuoo jialuoo marked this pull request as ready for review August 21, 2025 17:19
@jialuoo jialuoo requested review from a team as code owners August 21, 2025 17:19
shuoweil
shuoweil previously approved these changes Aug 21, 2025
func,
by_row: typing.Union[typing.Literal["compat"], bool] = "compat",
*,
args: typing.Tuple = (),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pandas args can be a positional argument while by_row is a keyword only argument https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.apply.html#pandas-series-apply. I would argue that we can adhere to that right now as I don't anticipate many people passing by_row positional argument, but if not, we should add an item in BigFrames 3.0 to make the breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, also thought about it. It’s difficult to fully match pandas API here so far. I have added some comments for potential breaking changes in the future. However, given that this is an edge case, I recommend we defer any such changes until there is a clear need based on user feedback.

@shuoweil shuoweil merged commit d9d725c into main Aug 25, 2025
25 checks passed
@shuoweil shuoweil deleted the series-args branch August 25, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants