Skip to content

fix: Fix row count local execution bug #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

fix: Fix row count local execution bug #2133

merged 3 commits into from
Oct 6, 2025
+61 −17

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #447638499 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 1, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 2, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review October 2, 2025 21:02
@TrevorBergeron TrevorBergeron requested review from a team as code owners October 2, 2025 21:02
@TrevorBergeron TrevorBergeron added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2025
@TrevorBergeron TrevorBergeron merged commit ece0762 into main Oct 6, 2025
21 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the row_count_pruning_fix branch October 6, 2025 21:21
@release-please release-please bot mentioned this pull request Oct 6, 2025
Merged
sycai pushed a commit that referenced this pull request Oct 7, 2025
@TrevorBergeron @sycai
fix: Fix row count local execution bug (#2133)
93706b6
sycai added a commit that referenced this pull request Oct 7, 2025
@sycai @TrevorBergeron
feat: add output_schema parameter to ai.generate() (#2139)
ef0b0b7 
* feat: add output_schema to ai.generate()

* fix lint

* fix lint

* fix test

* fix mypy

* fix lint

* code optimization

* fix tests

* support case-insensitive type parsing

* fix test

* fix: Fix row count local execution bug (#2133)

* fix: join on, how args are now positional (#2140)

---------

Co-authored-by: TrevorBergeron <tbergeron@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@ivansmf ivansmf

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @ivansmf