Skip to content

feat: support score() in GeminiTextGenerator #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2024
Merged

feat: support score() in GeminiTextGenerator #740

merged 4 commits into from
Jun 4, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #343789535 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu June 1, 2024 01:16
@ashleyxuu ashleyxuu requested review from a team as code owners June 1, 2024 01:16
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 1, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jun 1, 2024
GarrettWu
GarrettWu reviewed Jun 3, 2024
View reviewed changes
@ashleyxuu ashleyxuu force-pushed the ashleyxu-ml-evaluate-more branch from c0c2a7e to e8b663e Compare June 4, 2024 16:58
@ashleyxuu ashleyxuu force-pushed the ashleyxu-ml-evaluate-more branch from e8b663e to a68312d Compare June 4, 2024 17:48
@ashleyxuu ashleyxuu merged commit b2c7d8b into main Jun 4, 2024
@ashleyxuu ashleyxuu deleted the ashleyxu-ml-evaluate-more branch June 4, 2024 20:56
@release-please release-please bot mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@shobsi shobsi

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @GarrettWu @shobsi