Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: executemany rowcount only reflected the last execution #660

Merged
merged 1 commit into from May 12, 2021

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented May 11, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #659 馃

@google-cla google-cla bot added the cla: yes label May 11, 2021
@jimfulton jimfulton marked this pull request as ready for review May 11, 2021
@jimfulton jimfulton requested review from as code owners May 11, 2021
@jimfulton jimfulton requested review from shollyman and removed request for May 11, 2021
plamut
plamut approved these changes May 11, 2021
Copy link
Contributor

@plamut plamut left a comment

LGTM

Loading

@plamut plamut merged commit aeadc8c into master May 12, 2021
11 checks passed
Loading
@plamut plamut deleted the riversnake-fix-659 branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants