Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autogenerated snippet regionTags to match other languages #1051

Closed
alicejli opened this issue Oct 3, 2022 · 0 comments · Fixed by #1068
Closed

Update autogenerated snippet regionTags to match other languages #1051

alicejli opened this issue Oct 3, 2022 · 0 comments · Fixed by #1068
Assignees
@alicejli
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alicejli
Copy link
Contributor

alicejli commented Oct 3, 2022

Per SnippetGen configuration requirements:

  1. RegionTags should parse the defaultHost for the service name instead of the proto package
  2. RegionTags need to use the raw service and RPC method names
  3. RegionTags RPC names should be in upperCamelCase instead of lower case

b/239821325
b/246965359
@alicejli alicejli added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 3, 2022
@alicejli alicejli self-assigned this Oct 3, 2022
@alicejli alicejli added the samples Issues that are directly related to samples. label Oct 3, 2022
This was referenced Oct 3, 2022
Merged
Merged
@alicejli alicejli mentioned this issue Oct 25, 2022
Merged
suztomo pushed a commit that referenced this issue Mar 21, 2023
@release-please
chore(main): release 2.9.1-SNAPSHOT (#1051)
4089830 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alicejli alicejli

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixes regionTag breakage
1 participant
@alicejli