Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update regionTag to use service name #1047

Merged
merged 3 commits into from
Oct 24, 2022
Merged

fix: update regionTag to use service name #1047

merged 3 commits into from
Oct 24, 2022

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Sep 28, 2022 •
edited
Loading

Region tags for Java generated samples do not match other languages for Cloud Workflows.

Java current uses tags like workflows_v1_generated_workflowsclient_listworkflows_sync which includes workflowsclient. This doesn't match other languages that use tags like workflows_v1_generated_Workflows_ListWorkflows_sync. This prevents grouping of samples on the devsite.

This updates:

  1. The RegionTag to use the service name instead of the client name.
  2. The capitalization of the service and RPC name in the Region Tag

@snippet-bot
Copy link

snippet-bot bot commented Sep 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 871 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alicejli alicejli mentioned this pull request Sep 29, 2022
Merged
@alicejli alicejli marked this pull request as ready for review September 29, 2022 18:55
@alicejli alicejli requested review from a team as code owners September 29, 2022 18:55
@alicejli
Copy link
Contributor Author

alicejli commented Oct 3, 2022

#1051

@alicejli alicejli closed this Oct 17, 2022
@alicejli
Copy link
Contributor Author

Got stuck in rebasing hell - will generate a new PR for this change and link back here.

@alicejli alicejli reopened this Oct 17, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

1 similar comment
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@alicejli alicejli closed this Oct 19, 2022
@alicejli alicejli reopened this Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alicejli alicejli merged commit 68b33c2 into googleapis:main Oct 24, 2022
@release-please release-please bot mentioned this pull request Oct 24, 2022
Merged
@alicejli alicejli mentioned this pull request Oct 25, 2022
Merged
emmileaf pushed a commit that referenced this pull request Nov 3, 2022
@alicejli @emmileaf
fix: update regionTag to use service name (#1047)
38010fd 
* updating unit files and tests

* update integration tests

* refactor ClassNames
emmileaf added a commit that referenced this pull request Nov 3, 2022
@emmileaf
Revert "fix: update regionTag to use service name (#1047)"
1e3a935 
This reverts commit 38010fd.
emmileaf added a commit that referenced this pull request Nov 3, 2022
@emmileaf
Revert "fix: update regionTag to use service name (#1047)"
571f66d 
This reverts commit 38010fd.
emmileaf added a commit that referenced this pull request Nov 3, 2022
@emmileaf
fix: Revert "chore: merge main into autoconfig-gen-draft2" (#1083)
a8dfd80 
* Revert "test: update golden files after annotations import fix"

This reverts commit 0bbfc59.

* Revert "fix(ast): add import generation for annotations on VariableExpr (#1076)"

This reverts commit 9e4721f.

* Revert "chore(main): release 2.10.3 (#1079)"

This reverts commit 63b9bce.

* Revert "fix: fixes regionTag breakage (#1068)"

This reverts commit cd35be8.

* Revert "fix: fix REST transport client creation generated javadoc sample (#1077)"

This reverts commit 5346eef.

* Revert "refactor: expose parsed api short name and version as fields in Service (#1075)"

This reverts commit 2ebe948.

* Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.1 (#1072)"

This reverts commit 6774245.

* Revert "chore(main): release 2.10.2 (#1067)"

This reverts commit e8ee82f.

* Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 (#1063)"

This reverts commit aa1782d.

* Revert "fix: update regionTag to use service name (#1047)"

This reverts commit 38010fd.

* Revert "chore(main): release 2.10.1 (#1036)"

This reverts commit 3282e0f.

* Revert "deps: Upgrade protobuf to 3.21.7 (#1048)"

This reverts commit c768691.

* Revert "fix: update sample region tag to parse host instead of proto package (#1040)"

This reverts commit eb94f30.

* Revert "chore(deps): update dependency com.google.auto.value:auto-value to v1.10 (#1058)"

This reverts commit bd5599f.

* Revert "fix: Get numeric value for Enum fields if it is configured as query param or path param (#1042)"

This reverts commit 4b5eadb.

* Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 (#1050)"

This reverts commit e58bf9d.

* Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.33 (#1043)"

This reverts commit d615305.

* Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.0 (#1038)"

This reverts commit ce93705.

* Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 (#1039)"

This reverts commit dba69f4.

* Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.32 (#1037)"

This reverts commit e754a7c.
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@alicejli
fix: update regionTag to use service name (#1047)
be2f0b9 
* updating unit files and tests

* update integration tests

* refactor ClassNames
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
42faafa 
…onfig to v1.5.5 (#1047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicejli @blakeli0