Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock tests are generated for mixin APIs when they probably shouldn't be #790

Open
noahdietz opened this issue Jul 15, 2021 · 2 comments
Open

Mock tests are generated for mixin APIs when they probably shouldn't be #790

noahdietz opened this issue Jul 15, 2021 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@noahdietz
Copy link
Contributor

I was just testing a change to build_gen to introduce the Location pkg deps when the mixin is present and noticed in the generated output that MockLocations.java and MockLocationsImpl.java. I'm not sure that these should be generated since there isn't a Locations client generated, but I will let you @miraleung decide.
@noahdietz noahdietz added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 15, 2021
@noahdietz
Copy link
Contributor Author

noahdietz commented Jul 15, 2021 •
edited

You can repro with cl/384991546 bazel build //google/cloud/datastream/v1alpha1:google-cloud-datastream-v1alpha1-java

@miraleung
Copy link
Contributor

Thanks, earmarking for Fixit.

@miraleung miraleung removed the fixit label Jul 30, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Nov 3, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jan 11, 2022
@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 16, 2022
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Mar 16, 2022
@meltsufin meltsufin added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 4, 2022
suztomo pushed a commit that referenced this issue Mar 21, 2023
@renovate-bot
deps: update dependency com.google.auth:google-auth-library-bom to v1…
fdbab60 
….11.0 (#790)
suztomo pushed a commit that referenced this issue Mar 21, 2023
@release-please
chore(main): release 3.0.2 (#791)
25ec9b3 
🤖 I have created a release *beep* *boop*
---


## [3.0.2](googleapis/java-shared-dependencies@v3.0.1...v3.0.2) (2022-09-08)


### Dependencies

* Update dependency com.fasterxml.jackson:jackson-bom to v2.13.4 ([#789](googleapis/java-shared-dependencies#789)) ([d0b6888](googleapis/java-shared-dependencies@d0b6888))
* Update dependency com.google.auth:google-auth-library-bom to v1.10.0 ([#781](googleapis/java-shared-dependencies#781)) ([450a3fe](googleapis/java-shared-dependencies@450a3fe))
* Update dependency com.google.auth:google-auth-library-bom to v1.11.0 ([#790](googleapis/java-shared-dependencies#790)) ([fdbab60](googleapis/java-shared-dependencies@fdbab60))
* Update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#773](googleapis/java-shared-dependencies#773)) ([f59be02](googleapis/java-shared-dependencies@f59be02))
* Update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#776](googleapis/java-shared-dependencies#776)) ([8eddf23](googleapis/java-shared-dependencies@8eddf23))
* Update dependency com.google.protobuf:protobuf-bom to v3.21.5 ([#780](googleapis/java-shared-dependencies#780)) ([80c783f](googleapis/java-shared-dependencies@80c783f))
* Update dependency io.grpc:grpc-bom to v1.48.1 ([#768](googleapis/java-shared-dependencies#768)) ([c1e6978](googleapis/java-shared-dependencies@c1e6978))
* Update dependency io.grpc:grpc-bom to v1.49.0 ([#786](googleapis/java-shared-dependencies#786)) ([c5c4a0b](googleapis/java-shared-dependencies@c5c4a0b))
* Update dependency org.checkerframework:checker-qual to v3.24.0 ([#775](googleapis/java-shared-dependencies#775)) ([4bb5bee](googleapis/java-shared-dependencies@4bb5bee))
* Update dependency org.checkerframework:checker-qual to v3.25.0 ([#788](googleapis/java-shared-dependencies#788)) ([ad9e4f1](googleapis/java-shared-dependencies@ad9e4f1))
* Update dependency org.threeten:threetenbp to v1.6.1 ([#782](googleapis/java-shared-dependencies#782)) ([30717c3](googleapis/java-shared-dependencies@30717c3))
* Update gax.version to v2.19.0 ([#785](googleapis/java-shared-dependencies#785)) ([b5a674e](googleapis/java-shared-dependencies@b5a674e))
* Update google.core.version to v2.8.10 ([#787](googleapis/java-shared-dependencies#787)) ([754e622](googleapis/java-shared-dependencies@754e622))
* Update google.core.version to v2.8.7 ([#774](googleapis/java-shared-dependencies#774)) ([0c8e010](googleapis/java-shared-dependencies@0c8e010))
* Update google.core.version to v2.8.8 ([#777](googleapis/java-shared-dependencies#777)) ([e354fe1](googleapis/java-shared-dependencies@e354fe1))
* Update google.core.version to v2.8.9 ([#784](googleapis/java-shared-dependencies#784)) ([a9847d7](googleapis/java-shared-dependencies@a9847d7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Mar 21, 2023
@gcf-owl-bot @Neenu1995
chore: Enable Size-Label bot in all googleapis Java repositories (#1381…
462be7f 
…) (#790)

* chore: Enable Size-Label bot in all googleapis Java repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories

* Remove product

Remove product since it is by default true

* add license header

Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Source-Link: googleapis/synthtool@54b2c6a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:fc52b202aa298a50a12c64efd04fea3884d867947effe2fa85382a246c09e813

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miraleung @noahdietz @meltsufin @yoshi-automation