refactor(test): add util.chdir, util.copied_fixtures_dir contextmanagers to clean up tests #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(test): use chdir contextmanager to clean up some tests refactor(test): use chdir contextmanager to clean up some tests refactor(test): use chdir contextmanager to clean up some tests
google-cla
bot
added
the
cla: yes
chingor13
changed the title
SurferJeffAtGoogle
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.chdir(path)- changes the current working directory and restores the originalutil.copied_fixtures_dir(path)- copies an entire directory to a new temporary directory, chdirs into that directory, and restores the original current working directoryThese are 2 very common test setups that are used across the tests in this repository. It will help us ensure that we are correctly restoring the cwd between tests.