Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix move excludes #232

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Fix move excludes #232

merged 2 commits into from
Apr 29, 2019

Commits on Apr 25, 2019

  1. Fix move excludes 

    googleapis#48 introduced a bug where the exclude path (which is relative to a tracked path) is compared to a source path (which is relative to the source root).
This issue was unnoticed because it works ok when the source path has a single component like in firestore:
https://github.com/googleapis/nodejs-firestore/blob/89afae/synth.py#L19

But breaks when the source path has multiple components like in bigtable:
https://github.com/googleapis/google-cloud-java/blob/264643/google-cloud-clients/google-cloud-bigtable/synth.py#L30

And when the cwd doesn't match the tracked path
    @igorbernstein2
    igorbernstein2 committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    9b38ada View commit details
    Browse the repository at this point in the history

  2. format

    @igorbernstein2
    igorbernstein2 committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    7643a3a View commit details
    Browse the repository at this point in the history