Repository navigation
colab run: options after the script path are parsed by the CLI instead of being passed to the script #240
dreaifekks
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Version: google-colab-cli 0.8.0 (Linux); same code on main.
The help for
SCRIPT_ARGSsays "Anything after the script path is passed through verbatim", but withallow_extra_args/ignore_unknown_optionsClick still parses known options that appear after the script. For example, incolab run job.py --gpu T4 --timeout 60 -s foo,--gpu,--timeoutand-sgo tocolab run, not tojob.py. Before #211, a script's own--gpu <value>with a value colab didn't recognize started an A100.--works around it for those options, but not for--env:_extract_env_args_from_script_argsremoves--envfrom the script arguments even after--, so a script can't receive an--envflag at all.Suggestion: either make the help text say which options are still parsed after the script path, or stop parsing colab options once the script path is seen, and leave everything after
--untouched, including--env.Unrelated to the above, a +1 for the
_teardownchange in #231: I hit the case it fixes. An unassign failed at the end ofcolab run, the local record was removed anyway, and the VM stayed assigned and showed up as[?].All reactions