Verify gen-all-sdk-grpc #3310

Kalaiselvi84 · 2023-08-02T20:42:46Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3303

Special notes for your reviewer:

agones-bot · 2023-08-02T20:54:30Z

Build Failed 😱

Build Id: fdad105a-a9fa-4ac1-8b03-a5d6ad69bfe9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn

Looks good - small piece missing

zmerlynn · 2023-08-03T14:14:08Z

build/includes/sdk.mk

+# difference in sdks before and after gen-all-sdk-grpc target
+test-gen-all-sdk-grpc:
+	mkdir -p includes/tmp
+	cp -r ../sdks includes/tmp


It's also the test/sdk directory.

I have included the 'test/sdk' directory to compare the differences.

agones-bot · 2023-08-03T17:24:05Z

Build Failed 😱

Build Id: f81a0dbb-4d09-4c26-88aa-49f21fc41ccb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-03T17:30:12Z

Build Failed 😱

Build Id: 2fe410d1-d1fb-4d67-8b3e-2a7900c81168

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Kalaiselvi84 · 2023-08-03T17:39:24Z

make lint command is running without error in my local, but here it's failing🤔

google-oss-prow · 2023-08-03T17:50:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign roberthbailey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-08-03T17:55:13Z

Build Failed 😱

Build Id: 558e91fd-15de-4afe-8cee-a908b667c9c0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2023-08-03T18:10:01Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-08-22T22:06:50Z

Build Failed 😱

Build Id: 4d2b1334-f7af-4e72-a37d-68f8b90512f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T19:32:26Z

Build Failed 😱

Build Id: dac170ef-6ee2-4d78-a410-f17af642cd0e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T20:49:40Z

Build Failed 😱

Build Id: 0de32e08-be34-4177-a3e0-1389a49700ed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T21:05:42Z

Build Failed 😱

Build Id: f8fb2a1d-8568-44f0-8a6a-61eec3a691fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T21:18:07Z

Build Failed 😱

Build Id: 62024f34-687d-4191-a500-b487b70bca56

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T21:30:51Z

Build Failed 😱

Build Id: 89bf886b-86c1-435c-8825-832543a4f257

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-24T23:06:28Z

Build Failed 😱

Build Id: 409dae63-160d-409c-9d3a-6739211ce94a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…er tests This may be causing some sort of conflict in the tests in googleforgames#3310. Not sure why only googleforgames#3310 is seeing it, but it's not hard to make this consistent.

Kalaiselvi84 · 2023-08-25T17:42:52Z

The build issue for this PR is being addressed in #3349, and this PR will be closed.

@Kalaiselvi84

Adds a build step to verify that `make gen-all-sdk-grpc` has run. Credit to @Kalaiselvi84 for original googleforgames#3310 Sample output: ``` === Diffing workspace after 'make gen-all-sdk-grpc' *** Failure: Differences found: D sdks/rust/proto/allocation/allocation.proto D sdks/rust/proto/googleapis/google/api/annotations.proto D sdks/rust/proto/googleapis/google/api/client.proto D sdks/rust/proto/googleapis/google/api/field_behavior.proto D sdks/rust/proto/googleapis/google/api/http.proto D sdks/rust/proto/googleapis/google/api/launch_stage.proto D sdks/rust/proto/googleapis/google/api/resource.proto D sdks/rust/proto/grpc-gateway/LICENSE.txt D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/openapiv2.proto D sdks/rust/proto/sdk/alpha/alpha.proto D sdks/rust/proto/sdk/beta/beta.proto D sdks/rust/proto/sdk/sdk.proto ``` (Note this sample output was also what happens when I just run this check on my desktop because the `rust` generation spews files as root.)

…er tests This may be causing some sort of conflict in the tests in googleforgames#3310. Not sure why only googleforgames#3310 is seeing it, but it's not hard to make this consistent.

@Kalaiselvi84

Adds a build step to verify that `make gen-all-sdk-grpc` has run. Credit to @Kalaiselvi84 for original googleforgames#3310 Sample output: ``` === Diffing workspace after 'make gen-all-sdk-grpc' *** Failure: Differences found: D sdks/rust/proto/allocation/allocation.proto D sdks/rust/proto/googleapis/google/api/annotations.proto D sdks/rust/proto/googleapis/google/api/client.proto D sdks/rust/proto/googleapis/google/api/field_behavior.proto D sdks/rust/proto/googleapis/google/api/http.proto D sdks/rust/proto/googleapis/google/api/launch_stage.proto D sdks/rust/proto/googleapis/google/api/resource.proto D sdks/rust/proto/grpc-gateway/LICENSE.txt D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/openapiv2.proto D sdks/rust/proto/sdk/alpha/alpha.proto D sdks/rust/proto/sdk/beta/beta.proto D sdks/rust/proto/sdk/sdk.proto ``` (Note this sample output was also what happens when I just run this check on my desktop because the `rust` generation spews files as root.)

@Kalaiselvi84

* Move the restapi folder GRPC_PORT off of the same port as the go folder tests This may be causing some sort of conflict in the tests in #3310. Not sure why only #3310 is seeing it, but it's not hard to make this consistent. * Verify gen-all-sdk-grpc has run Adds a build step to verify that `make gen-all-sdk-grpc` has run. Credit to @Kalaiselvi84 for original #3310 Sample output: ``` === Diffing workspace after 'make gen-all-sdk-grpc' *** Failure: Differences found: D sdks/rust/proto/allocation/allocation.proto D sdks/rust/proto/googleapis/google/api/annotations.proto D sdks/rust/proto/googleapis/google/api/client.proto D sdks/rust/proto/googleapis/google/api/field_behavior.proto D sdks/rust/proto/googleapis/google/api/http.proto D sdks/rust/proto/googleapis/google/api/launch_stage.proto D sdks/rust/proto/googleapis/google/api/resource.proto D sdks/rust/proto/grpc-gateway/LICENSE.txt D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/openapiv2.proto D sdks/rust/proto/sdk/alpha/alpha.proto D sdks/rust/proto/sdk/beta/beta.proto D sdks/rust/proto/sdk/sdk.proto ``` (Note this sample output was also what happens when I just run this check on my desktop because the `rust` generation spews files as root.)

Verify gen-all-sdk-grpc

e869cc3

google-oss-prow bot requested review from aLekSer and cyriltovena August 2, 2023 20:42

google-oss-prow bot added the size/S label Aug 2, 2023

Kalaiselvi84 requested a review from markmandel August 2, 2023 20:42

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 2, 2023

Kalaiselvi84 requested review from zmerlynn and removed request for cyriltovena and aLekSer August 2, 2023 20:43

zmerlynn reviewed Aug 3, 2023

View reviewed changes

Kalaiselvi84 added 2 commits August 3, 2023 17:15

included test/sdk directory to compare

94e672e

Merge branch 'main' into pr_3303

c89da17

fix linting issue

683e473

google-oss-prow bot added size/M and removed size/S labels Aug 3, 2023

zmerlynn approved these changes Aug 3, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn Aug 3, 2023

google-oss-prow bot added the lgtm label Aug 3, 2023

zmerlynn enabled auto-merge (squash) August 3, 2023 17:50

revert last change

b8748e6

google-oss-prow bot removed the lgtm label Aug 3, 2023

google-oss-prow bot added size/S and removed size/M labels Aug 3, 2023

Merge branch 'main' into pr_3303

d3d50d5

both diff and git diff

5f54f38

google-oss-prow bot added size/M and removed size/S labels Aug 24, 2023

clean build/.gocache

c4ab993

google-oss-prow bot added size/S and removed size/M labels Aug 24, 2023

syntax issue

c5e6ead

no comments

57e6905

Kalaiselvi84 added 2 commits August 24, 2023 21:34

included -rf

c384055

modify path

a78eae7

zmerlynn mentioned this pull request Aug 25, 2023

Move the restapi folder GRPC_PORT off of the same port as the go folder tests #3348

Closed

zmerlynn added a commit to zmerlynn/agones that referenced this pull request Aug 25, 2023

(copy of PR googleforgames#3310)

551c4a3

zmerlynn mentioned this pull request Aug 25, 2023

Verify gen-all-sdk-grpc has run #3349

Merged

Kalaiselvi84 closed this Aug 25, 2023

Kalaiselvi84 deleted the pr_3303 branch March 15, 2024 01:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify gen-all-sdk-grpc #3310

Verify gen-all-sdk-grpc #3310

Kalaiselvi84 commented Aug 2, 2023

agones-bot commented Aug 2, 2023

zmerlynn left a comment

zmerlynn Aug 3, 2023

Kalaiselvi84 Aug 3, 2023

agones-bot commented Aug 3, 2023

agones-bot commented Aug 3, 2023

Kalaiselvi84 commented Aug 3, 2023

google-oss-prow bot commented Aug 3, 2023

agones-bot commented Aug 3, 2023

google-oss-prow bot commented Aug 3, 2023

agones-bot commented Aug 22, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

Kalaiselvi84 commented Aug 25, 2023

Verify gen-all-sdk-grpc #3310

Verify gen-all-sdk-grpc #3310

Conversation

Kalaiselvi84 commented Aug 2, 2023

agones-bot commented Aug 2, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

zmerlynn Aug 3, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 3, 2023

Choose a reason for hiding this comment

agones-bot commented Aug 3, 2023

agones-bot commented Aug 3, 2023

Kalaiselvi84 commented Aug 3, 2023

google-oss-prow bot commented Aug 3, 2023

agones-bot commented Aug 3, 2023

google-oss-prow bot commented Aug 3, 2023

agones-bot commented Aug 22, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

Kalaiselvi84 commented Aug 25, 2023