Skip to content

Sarthak refactoring #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Nov 9, 2022
Merged

Sarthak refactoring #1

merged 28 commits into from
Nov 9, 2022

Conversation

anglarett
Copy link
Collaborator

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

anubis05 and others added 28 commits November 3, 2022 09:54
@anubis05
linting
8a36255
@anubis05
Refactored the result parsing code
1b9928f
@anubis05
added test script for result parser
aaecfe0
@anubis05
* Updated logic for address metadata
758fd87
@anubis05
* Changes to config
a6beb08
@anubis05
* Additional modifications to the parser
9d68fc0
@anubis05
Added CSV files to gitignore
3b7f200
@anubis05
Removed all *.csv files from being tracked
7d39964
@anubis05
* Refactor av_parser class
1b823b6
@anubis05
*Converted variables to static variables
0ea94fe
@anubis05
* Created new function for address metadata separate from USPS function
14d0329
@anubis05
* minor commenting changes
3a81df0
@anglarett
main
1c51a90
@anglarett
main
c7ddb25
@anglarett
update
ae0bf48
@anglarett
update
5212b06
@anglarett
update
10fef97
@anglarett
update
2402257
@anglarett
update
4bdc5b6
@anubis05
Moved all test files to tests folder outside src/
7a49ce0
@anubis05
* moving test files outside of src
e1f7a5b
@anubis05
Merge branch 'Sarthak_refactoring' of github.com:googlemaps/python-hi…
9031467 
…gh-volume-address-validation-library into Sarthak_refactoring
@anubis05
* Updated redme file and removed dead code
9f37dfa
@anubis05
* Added License information and specific details of mode
0f0dc8c
@anubis05
Removed some repetative elements from the readme file
f6269f7
@anubis05
* Removed a temp file
52b8a87
@anubis05
* Converted to a unit test class
c3f928c
@anubis05
* Cleaned unused code
7ccb7dc
@anglarett anglarett self-assigned this Nov 9, 2022
@anglarett anglarett merged commit 3e0683c into main Nov 9, 2022
@anglarett anglarett deleted the Sarthak_refactoring branch November 9, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anglarett anglarett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anglarett @amuramoto @anubis05