Barcode Reader - SurfaceView Fullscreen

[davidtcdeveloper]

Hi,

I am using the barcode-reader as a sample for barcode reading with the Mobile Vision.
The problem is that in many devices, due to camera specs, the preview is not large enough to fill the hole screen, as in the screen below.
Is there anyway to make it full screen (match_parent)?
I tried to set layout parameters to the surfaceview in the CameraSourcePreview class, but it didn't work.
Do you have any other suggestion?

[davidtcdeveloper]

Kind of obvious, I forgot to check the onLayout from CameraSourcePreview.

[Martin-Hogge]

Could you please tell me how did you manage to get fullscreen preview by checking the "onLayout" method?

[davidtcdeveloper]

@Shargotth

At the class CameraSourcePreview, in the method onLayout, I replaced the following lines.

for (int i = 0; i < getChildCount(); ++i) {
    getChildAt(i).layout(0, 0, layoutWidth, layoutHeight);
}

By these lines:

        // Computes height and width for potentially doing fit width.
        int childWidth = layoutWidth;
        int childHeight = (int)(((float) layoutWidth / (float) width) * height);

        // If height is too tall using fit width, does fit height instead.
        if (childHeight > layoutHeight) {
            childHeight = layoutHeight;
            childWidth = (int)(((float) layoutHeight / (float) height) * width);
        }

        for (int i = 0; i < getChildCount(); ++i) {
            getChildAt(i).layout(0, 0, childWidth, childHeight);
        }

[Martin-Hogge]

Thank you for your quick answer.

But with those lines, when I'm passing the width & height of my screen (1080 x 1845) the surfaceView doesn't fit the screen, do you have any clue why?

With thoses values I got childWidth = 1080 & childHeight = 1440.

Isn't it possible to get full camera preview size without deformation of the preview?

[davidtcdeveloper]

I can't tell you for sure what's going on.
Can you post the entire onLayout method?

[Martin-Hogge]

Here it is :

@Override
    protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
        int width = 320;
        int height = 240;
        if (mCameraSource != null) {
            Size size = mCameraSource.getPreviewSize();
            if (size != null) {
                width = size.getWidth();
                height = size.getHeight();
            }
        }

        // Swap width and height sizes when in portrait, since it will be rotated 90 degrees
        if (isPortraitMode()) {
            int tmp = width;
            //noinspection SuspiciousNameCombination
            width = height;
            height = tmp;
        }

        final int layoutWidth = right - left;
        final int layoutHeight = bottom - top;

        // Computes height and width for potentially doing fit width.
        int childWidth = layoutWidth;
        int childHeight = (int)(((float) layoutWidth / (float) width) * height);

        // If height is too tall using fit width, does fit height instead.
        if (childHeight > layoutHeight) {
            childHeight = layoutHeight;
            childWidth = (int)(((float) layoutHeight / (float) height) * width);
        }

        for (int i = 0; i < getChildCount(); ++i) {
            getChildAt(i).layout(0, 0, childWidth, childHeight);
        }

        try {
            startIfReady();
        } catch (SecurityException se) {
            Log.e(TAG,"Do not have permission to start the camera", se);
        } catch (IOException e) {
            Log.e(TAG, "Could not start camera source.", e);
        }
    }

[davidtcdeveloper]

My bad, I think I did post the wrong code.
Here is how my method is right now.

@Override
    protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
        int width = 320;
        int height = 240;
        if (mCameraSource != null) {
            Size size = mCameraSource.getPreviewSize();
            if (size != null) {
                width = size.getWidth();
                height = size.getHeight();
            }
        }

        // Swap width and height sizes when in portrait, since it will be rotated 90 degrees
        if (isPortraitMode()) {
            int tmp = width;
            //noinspection SuspiciousNameCombination
            width = height;
            height = tmp;
        }

        final int layoutWidth = right - left;
        final int layoutHeight = bottom - top;

        for (int i = 0; i < getChildCount(); ++i) {
            getChildAt(i).layout(0, 0, layoutWidth, layoutHeight);
        }
        startIfReady();
    }

[Martin-Hogge]

It works like a charm. Thank's !

[AsilkhanLisak]

Hi, I did app with fullscreen image from camera source, but its image stretched, how to edit, control images proportions. I mean how to adapt camera source size on to preview size(doesnt matter preview is fullscreen, 1/4 screen etc).