Skip to content

Merge 2 patches for presentation sync and image layout fix #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2017
Merged

Merge 2 patches for presentation sync and image layout fix #23

merged 2 commits into from
May 10, 2017

Conversation

ggfan
Copy link
Contributor

@ggfan ggfan commented May 10, 2017

No description provided.

ek9852 added 2 commits May 10, 2017 09:55
@ek9852 @ggfan
Fix pWaitDstStageMask is null problem
b0c89c0 
According to specification:
If waitSemaphoreCount is not 0, pWaitDstStageMask must be a pointer
to an array of waitSemaphoreCount valid combinations of
VkPipelineStageFlagBits values

Signed-off-by: guanghuafan <gfan@google.com>
@ek9852 @ggfan
Layout should be VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
ec349c3 
Set to corret flag when creating render pass for presentable
image

Signed-off-by: guanghuafan <gfan@google.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ggfan
Copy link
Contributor Author

ggfan commented May 10, 2017

@ek9852 @cnorthrop @bbilodeau please review, if oked, I will merge it.

@ek9852
Copy link
Contributor

ek9852 commented May 10, 2017 •
edited
Loading

Looks good to me. Ok to merge.

@bbilodeau
Copy link

LGTM

@ggfan ggfan merged commit b1b5f89 into master May 10, 2017
@ggfan ggfan deleted the wait-dst-stage-mask branch May 19, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggfan @googlebot @ek9852 @bbilodeau