Fixed code style consistency more #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As someone who has looked and used all these tutorials I noticed a small trend of deviation from the consistent styling from the first few tutorials. Since this might be someone else first time learning how to write android vulkan code I feel a consistence styling makes the code more readable
sjfricke
commented
Sep 2, 2017
| @@ -207,6 +207,17 @@ void CreateSwapChain() { | |||
| LOGI("<-createSwapChain"); | |||
| } | |||
|
|
|||
| void DeleteSwapChain(void) { | |||
There was a problem hiding this comment.
The DeleteSwapChain under the CreateSwapChain as all the other "Create..." have the "Delete..." under it
sjfricke
commented
Sep 2, 2017
| @@ -64,14 +64,14 @@ struct VulkanSwapchainInfo { | |||
| VulkanSwapchainInfo swapchain; | |||
|
|
|||
| struct VulkanBufferInfo { | |||
| VkBuffer vertexBuf; | |||
| VkBuffer vertexBuf_; | |||
There was a problem hiding this comment.
keeping the idea of these Vulkan struct groups ending with an underscore
|
LGTM. could you save your code locally, then try with |
|
Wow, I can't believe I didn't know about clang-format, that gonna save me so much time in my life in the future |
|
thanks for PR. merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As someone who has looked and used all these tutorials, I noticed a small trend of deviation from the consistent styling from the first few tutorials. Since this might be someone else first time learning how to write android Vulkan code I feel a consistency styling makes the code more readable.
Ran all tutorials to confirm still build and run