Update build script to Android Studio 3.0.0 #41
Conversation
|
@adarshf may you have a look too? thanks |
|
lgtm |
README.md
Outdated
| @@ -32,7 +32,7 @@ Refer to README.md under its directory | |||
| Pre-requisites | |||
| -------------- | |||
| - Android N device, API >= 24 | |||
| - Android Studio 2.2 beta1 or better | |||
| - Android Studio 3.0 better (this is a must in order to build the sample here) | |||
There was a problem hiding this comment.
Just say the following (no need to repeat that this is a requirement):
- [Android Studio 3.0](https://developer.android.com/studio/index.html) or higher.
README.md
Outdated
| @@ -32,7 +32,7 @@ Refer to README.md under its directory | |||
| Pre-requisites | |||
| -------------- | |||
| - Android N device, API >= 24 | |||
There was a problem hiding this comment.
"A device running Android 7.0 (API level 24) or higher."
README.md
Outdated
| @@ -32,7 +32,7 @@ Refer to README.md under its directory | |||
| Pre-requisites | |||
| -------------- | |||
| - Android N device, API >= 24 | |||
| - Android Studio 2.2 beta1 or better | |||
| - Android Studio 3.0 better (this is a must in order to build the sample here) | |||
| - Android NDK | |||
| * [NDK-r12](https://github.com/android-ndk/ndk/wiki), compile as is | |||
There was a problem hiding this comment.
Users would simply get the NDK through the SDK manager, no? It may be easier to point users here for the NDK components: https://developer.android.com/studio/projects/add-native-code.html#download-ndk
README.md
Outdated
| @@ -41,17 +41,14 @@ Test Matrix | |||
| ------------ | |||
| | Andrid Studio Version | cmake in SDK| NDK | Result | | |||
There was a problem hiding this comment.
I would get rid of this table. We already say that users should use AS 3.0+, and the link I provide in the comment above describes how to install CMake.
There was a problem hiding this comment.
for open source project, like to get to what we tested with. Mainly there are so many combinations and users would always have different combinations etc., when problem happens, we would know at the time what was tested with, so we could go that configuration to make sure it is still working, then debugging the new combinations
README.md
Outdated
|
|
||
| Known Issue: | ||
| - r13-beta layer source needed to be updated | ||
| - Studio Beta cmake 3.6.3133135 having issues with r13-beta | ||
|
|
||
| Getting Started | ||
| --------------- | ||
| 1. [Download Android Studio](http://tools.android.com/download/studio/canary) |
There was a problem hiding this comment.
I would remove the first two steps, as you've already included them as prerequisites.
| @@ -2,7 +2,7 @@ apply plugin: 'com.android.application' | |||
|
|
|||
| android { | |||
| compileSdkVersion 24 | |||
| buildToolsVersion '25.0.0' | |||
| buildToolsVersion '26.0.2' | |||
| // force debug layer lib is used in packing | ||
| compile project(path: ':layerlib', configuration: 'debug') | ||
| // compile project(path: ':layerlib', configuration: 'debug') | ||
| compile project(':layerlib') |
| // force debug layer lib is used in packing | ||
| compile project(path: ':layerlib', configuration: 'debug') | ||
| // compile project(path: ':layerlib', configuration: 'debug') |
There was a problem hiding this comment.
If you leave this in here, perhaps include a comment describing why specifying the variant is no longer required. Feel free to point to this link: https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#variant_dependencies
| @@ -17,7 +17,7 @@ android { | |||
| publishNonDefault true | |||
|
|
|||
| compileSdkVersion 24 | |||
| buildToolsVersion '25.0.0' | |||
| buildToolsVersion '26.0.2' | |||
There was a problem hiding this comment.
please remove all buildToolsVersion properties.
| @@ -13,7 +13,9 @@ android { | |||
|
|
|||
| ndk.abiFilters 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64' | |||
| externalNativeBuild { | |||
| cmake.arguments '-DANDROID_TOOLCHAIN=clang', '-DANDROID_STL=c++_static' | |||
| cmake.arguments '-DANDROID_TOOLCHAIN=clang', | |||
There was a problem hiding this comment.
Does this actually work with single quotes? I remember not using double quotes (") being an issue, but I may be mistaken.
There was a problem hiding this comment.
works fine for me. double quota is for macro expansion. Single quota is "take as is"
Update the android build tool version to 3.0.0 according to:
https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html