General improvements #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 22, 2018 08:50
From the Vulkan spec we need to add HOST_COHERENT as it says: If a memory object does not have the VK_MEMORY_PROPERTY_HOST_COHERENT_BIT property, then vkFlushMappedMemoryRanges must be called in order to guarantee that writes to the memory object from the host are made visible to the VK_ACCESS_HOST_WRITE_BIT access type, where it can be further made available to the device by synchronization commands
The good practice is to map allocation size, this is also done for the texutre data so keepit consistent across all map memory
|
thanks for the PR. The changes around mem_req are needed indeed; the validation layer handling is outdated: Vulkan merged device and instance layers ( I am pretty sure about it ) so there is no need to do device layers anymore. You may try to delete the device layer handling and confirm it still would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.allocationSizeVK_MEMORY_PROPERTY_HOST_COHERENT_BITto vertex memoryvkMapMemorywith allocation size instead of vector/struct sizeVulkan Debug Message->Vulkan-Debug-Messageso it can be regex search in logcat easierAAsset*withAAsset_close