Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Fix JaCoCo error #267

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Fix JaCoCo error #267

merged 3 commits into from
Dec 21, 2018

Conversation

henriquenfaria
Copy link
Contributor

  • Migrate to gradle-android-junit-jacoco-plugin
  • Update robolectric, shadows-supportv4 and mockito-core dependencies

@samtstern
Copy link
Contributor

I see we're moving to a plugin by the one and only @vanniktech! LGTM, will merge if green.

@henriquenfaria
Copy link
Contributor Author

Travis builds are failing since August. This PR fixes that by using another jacoco plugin and updating our testing libraries.

@henriquenfaria
Copy link
Contributor Author

I see we're moving to a plugin by the one and only @vanniktech! LGTM, will merge if green.

It's green now :)

@samtstern samtstern merged commit d5b707c into googlesamples:master Dec 21, 2018
@samtstern
Copy link
Contributor

Huh yeah you're right:
https://travis-ci.org/googlesamples/easypermissions/builds/448334619

I wonder why I never noticed the build failures! Thanks for being on top of it.

@henriquenfaria henriquenfaria deleted the fix-jacoco branch December 21, 2018 17:44
@vanniktech
Copy link

vanniktech commented Dec 24, 2018

My pleasure ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants