Translate showcase cleanups #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Update non-cameraX dependencis • Replace deprecated use of ViewModelProviders.of() with viewModels() property delegate • Remove unnecessary Companion references • Replace use of this as lifecycle owner with viewLifecycleOwner
sheepmaster
approved these changes
Jun 6, 2020
|
Sure! Added internal cl number in description |
This was referenced Oct 26, 2021
ta-tomschell
pushed a commit
to ta-tomschell/mlkit
that referenced
this pull request
Apr 4, 2025
…anslate_showcase_improvements Translate showcase cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal CL: 153272
• Update non-cameraX dependencis
• Replace deprecated use of ViewModelProviders.of() with viewModels()
property delegate
• Remove unnecessary Companion references
• Replace use of this as lifecycle owner with viewLifecycleOwner