README Plugin Redistribution section issues

[s-hocking]

I think the "Plugin Redistribution" section of the README has a couple of issues.

1. The command given in the Plugin Redistribution section of the README is missing a path for the -importPackage argument. I'm guessing it should be something like -importPackage ./play-services-resolver-1.2.46.0.unitypackage?

2. There's a typo in this sentence:

The build of the Play Services Resolver plugin has Unity asset metadata that is configured to so that the all editor components...

3. The current text seems to be more about how to update an existing Play Services Resolver integration in a plugin project, without clobbering the gvh metadata. It doesn't really describe how to redistribute the plugin, nor in what situations I would want to do that. Is it as simple as including the PlayServicesResolver directory contents in my plugin? Is there ever an argument for not redistributing the plugin? As a Unity newbie it would help to have these details spelled out.

Thanks for reading.

[s-hocking]

Another question: when redistributing the Play Services Resolver, should I include the Play Services Resolver files in my manifest?

[stewartmiles]

Sure we can update the readme with some more details, we're also happy to accept pull requests.

w.r.t including the files in your manifest, yeah it doesn't hurt. The Version Handler will just associate the files with both the Play Services Resolver plugin and your plugin. The idea - though it hasn't been implemented yet - is that it would be possible to remove plugins as well as handling upgrades using file -> plugin association via the manifests.

[s-hocking]

Thanks @stewartmiles, happy to submit a PR to tidy things up a bit.

Just so I know for when I'm updating the README: is there anything more to redistributing the plugin than simply including the PlayServicesResolver directory contents in my plugin?

[stewartmiles]

@s-hocking the key bit of https://github.com/googlesamples/unity-jar-resolver#plugin-redistribution is disabling the version handler when building a Unity package using -gvh_disable since we want to defer the selection of the plugin version until the user imports it into their project.