Skip to content

Conversation

unace
Copy link
Contributor

@unace unace commented Feb 17, 2020

add some lines to handle a new Unity OpenJDK path.
before
/Applications/Unity/Hub/Editor/{UnityVersion}/PlaybackEngines/AndroidPlayer/Tools/OpenJDK/{platform}
after
/Applications/Unity/Hub/Editor/{UnityVersion}/PlaybackEngines/AndroidPlayer/OpenJDK/

add some lines to handle a new Unity OpenJDK path.
before
/Applications/Unity/Hub/Editor/{UnityVersion}/PlaybackEngines/AndroidPlayer/Tools/OpenJDK/{platform}
after
/Applications/Unity/Hub/Editor/{UnityVersion}/PlaybackEngines/AndroidPlayer/OpenJDK/
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@unace
Copy link
Contributor Author

unace commented Feb 17, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@stewartmiles stewartmiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

@stewartmiles stewartmiles merged commit d963ddf into googlesamples:master Feb 19, 2020
unace pushed a commit to unace/unity-jar-resolver that referenced this pull request Feb 29, 2020
Since 2019.3 version, Unity has changed embedded JDK path and provided UnityEditor.Android.AndroidExternalToolsSettings.jdkRootPath API (https://docs.unity3d.com/2019.3/Documentation/ScriptReference/Android.AndroidExternalToolsSettings-jdkRootPath.html).
Previous MR(googlesamples#325) wasn't enough to handle embedded JDK path, so I reverted it and changed codes to use Unity API.
@googlesamples googlesamples locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants