Properly support pods with static library and Swift Framework #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default value of "Link Framework statically" in iOS Resolver settings to TRUE since it is very likely that some pod frameworks includes pre-built static libraries, and can cause unexpected crash in runtime if the app is build with with multiple targets (Unity 2019.3+).
The Xcode project generate from Unity may not be able to link Swift Standard Libaries properly if 1. Some pods include Swift frameworks 2. Podfile sets to link frameworks statically The workround attempts to fix this by 1. Add a Dummy.swift file to the Xcode project. 2. Enable `CLANG_ENABLE_MODULES` and `ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES` build settings. 3. Change `SWIFT_VERSION` to the value specified in iOS Resolver settings. Default to "5". This workaround is turned OFF by default.
|
Test with Analytics testapp, FirebaseAnalytics 8.8.0 (.unitypackage. This depends on a pod containing static library) and Facebook Unity SDK (this depends on a pod containing Swift Framework). and Xcode Due to that Facebook SDK always append Verified in the following Unity versions
|
AlmostMatt
reviewed
Apr 1, 2022
The Xcode project generate from Unity may not be able to link Swift Standard Libaries properly if 1. Some pods include Swift frameworks 2. Podfile sets to link frameworks statically The workround attempts to fix this by 1. Add a Dummy.swift file to the Xcode project. 2. Enable `CLANG_ENABLE_MODULES` and `ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES` build settings. 3. Change `SWIFT_VERSION` to the value specified in iOS Resolver settings. Default to "5". This workaround is turned OFF by default.
a-maurice
approved these changes
Apr 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more context b/196153528
A couple of changes:
Link Framework Staticallysetting default value totrueLink Framework Staticallyistrue. This workaround is turnedOFFby default. It basically does the followinga. Add a
dummy.swiftfile to Xcode projectb. Set
SWIFT_VERSIONbuild property. If Xcode project has multiple targets (generated by Unity 2019.3+), then also enableCLANG_ENABLE_MODULESandALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES