Workaroud when AssetDatabase.CreateFolder failed
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With certain version of Unity, ex. 2022.2.0b8 or 2023.1.0a11, `AssetDatabase.CreateFolder()` can fail when the folder name is version number like `9.0.0`. In this case, the API does not return empty guid but a guid with zeroes. This change make sure that the folder can still be created using `Directory.CreateDirectory()`, which may not trigger AssetDatabase refresh in the older version of Unity.
|
@a-maurice @DellaBitta hey, it's some critical bug. @CheeryLee investigated that problem and find out that it's unity bug and it reproduces in most 2022+ unity versions his message. |
DellaBitta
approved these changes
Sep 30, 2022
chkuang-g
added a commit
that referenced
this pull request
Oct 4, 2022
Follow up for #543. When Unity failed to create folder using Unity API `AssetDatabase.CreateFolder()`, even with the workaround in #543, Unity would still generate two error message and there is no way to turn it off. This change add an additional log after Unity API fails to inform the user to ignore this error.
chkuang-g
added a commit
that referenced
this pull request
Oct 5, 2022
* Add log when Unity failed to create folder Follow up for #543. When Unity failed to create folder using Unity API `AssetDatabase.CreateFolder()`, even with the workaround in #543, Unity would still generate two error message and there is no way to turn it off. This change add an additional log after Unity API fails to inform the user to ignore this error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With certain version of Unity, ex. 2022.2.0b8 or 2023.1.0a11,
AssetDatabase.CreateFolder()can fail when the folder name is version number like9.0.0. In this case, the API does not return empty guid but a guid with zeroes.This change make sure that the folder can still be created using
Directory.CreateDirectory(), which may not trigger AssetDatabase refresh in the older version of Unity.