Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborg movement speed rebalance #17577

Merged
merged 4 commits into from Feb 15, 2024

Conversation

ThatFiveGuys
Copy link
Contributor

@ThatFiveGuys ThatFiveGuys commented Jan 6, 2024

About the PR

I'd like to preface this by saying that I think this should be testmerged before merging, I cannot do sufficient testing besides making sure my code actually does what I want it to do and the speed feel right on a local. I think my values are good, but it's hard to say without seeing them in practice.

This pr changes the movement modifier of nearly every single borg part in the game. Below is a chart of all the previous and new values, alongside a few presets (the rp meta is light borg w/ screenhead + treads). The human speed sus. is the speed of a base full health human after 10 tiles (the speed below that is 1.7).
image

The key playerside changes are as follows, each heavier part now has an increasing effect on movement speed. Light borg's movement speed is unaffected, but light borg with treads is ~30% slower. Every borg above light borg with the exception of heavy borg w/ treads is faster, but treads have relatively less impact on speed. Thrusters are now slightly better speed wise then treads in every scenario.

For code side changes, weight no longer effects movement speed as it just makes balancing these values harder to minimal benefit. The weight variable is left in code in case anyone wants to use them for future borg expansions, however that variable is not used for anything. Any dev tell me if you want it removed and I will do so.

Why's this needed?

In short, light borgs w/ treads are too fast, and heavier borgs are too slow. This should make heavier borgs more playable, and light borgs less desirable. Also its kinda weird that standard chests are objectively better then light chests in every way, like that isnt right.

Changelog

(u)Ikea
(*)Borg speed values have been changed all across the board. Treadless light borgs are the same speed. Light and heavy borgs with treads are now slower compared to before. Every other borg body type is faster, see pr for specific values. 

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2024
@ThatFiveGuys ThatFiveGuys added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. A-Silicons Deals with the angry metal robots labels Jan 6, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22156

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jan 8, 2024
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jan 10, 2024
Copy link
Contributor

@mordent-goonstation mordent-goonstation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://forum.ss13.co/showthread.php?tid=22156&pid=200165#pid200165

Hold on the no-arms case being considered. Broadly fine with the changes as described, may need some more tweaking and fine-tuning after live play. I do not think this needs test merging, we can adjust iteratively.

@ThatFiveGuys
Copy link
Contributor Author

Changes requested implemented

@ThatFiveGuys
Copy link
Contributor Author

BigDocOfSpeed.xlsx
If anyone wants to play around with the spreadsheet, here it is

@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Jan 24, 2024
@Tarmunora Tarmunora merged commit b3aea36 into goonstation:master Feb 15, 2024
23 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Silicons Deals with the angry metal robots C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants