-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config file relies on tabs and spaces #2910
Comments
You can use the git INI generator https://github.com/NixOS/nixpkgs/blob/cae5d2c7116805121977e4a97616f3e356be15ce/lib/generators.nix#L353 |
I would argue that Nix has an ... interesting approach. But I don't think our parser should require the tabs. That seems unnecessary. The spaces around the equal signs however make more sense and I think we should keep this as is. |
I took a look at the current implementation. Tabs are not required. We're removing any whitespace early on. Spaces around the equal sign are currently required but I think we could ease the if that's what the INI spec requires. |
syntax specification. The gitconfig format (which is an INI format) does recommend but not require whitespaces around equal signs that separate keys and values. Fixes gopasspw#2910 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
LGTM thanks 👋 |
I built my
$XDG_CONFIG_HOME/gopass/config
using Nix, but I had to do some ugly fiddling, to make it work:The
\t
and the spaces around the=
were necessary to make the INI format look like this:and not like it would generate it without them:
With the latter,
gopass mounts
would simply return that it won't find any configured mounts.The Nix community argues,
gopass
would be too picky with the file format, as INI itself would not rely on those tabs and spaces.The text was updated successfully, but these errors were encountered: