Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add option to disable notification icon #2845

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[feat] Add option to disable notification icon #2845

merged 2 commits into from
Mar 29, 2024

Conversation

dominikschulz
Copy link
Member

Fixes #2810

@dominikschulz
[feat] Add option to disable notification icon
f998319 
Fixes gopasspw#2810

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added this to the 1.15.13 milestone Mar 28, 2024
AnomalRoil
AnomalRoil requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the required documentation for this new option.

@dominikschulz
[chore] Document new config option
820d204 
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz merged commit 9b41761 into gopasspw:master Mar 29, 2024
7 of 8 checks passed
@dominikschulz dominikschulz deleted the fix/issue-2810 branch March 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.13
Development

Successfully merging this pull request may close these issues.

Feature request: configuration option to disable logo in notification
2 participants
@dominikschulz @AnomalRoil