-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ReferenceNodes usage with mask set #683
Conversation
Another way would be to add a factory function to |
I think your idea for a static factory function sounds cleanest. It would make it clear what is happening, and who should be using it. |
f20bc2f
to
5f8da7d
Compare
ok, I rebased the branch on main (not sure if that was necessary) and added a commit migrating this to the factory function (method). Instead adding it as a static I added it to client analogous to the |
Can you add a few tests to cover the conversion? |
sure will do |
this proves that the mask will be correct
731d545 contains the most relevant test where the arguments ensure the flag is set and the conversion ensure those are unset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Prosys Sim 5.4.6 and Azure IoTEdge 1.4.371.60
resolves #682
resolves #550