Skip to content

Pin goimport dep to a version that works with go 1.14 #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

Pin goimport dep to a version that works with go 1.14 #2620

merged 1 commit into from
May 17, 2023

Conversation

mandre
Copy link
Contributor

@mandre mandre commented May 17, 2023

Fixes the unit tests when running with go 1.14.

@coveralls
Copy link

Coverage Status

Coverage: 79.139%. Remained the same when pulling 44ddb19 on shiftstack:unit_tests_1-14 into f41487e on gophercloud:master.

@mandre mandre mentioned this pull request May 17, 2023
Merged
pierreprinetti
pierreprinetti approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@pierreprinetti pierreprinetti merged commit 33412be into gophercloud:master May 17, 2023
@pierreprinetti pierreprinetti deleted the unit_tests_1-14 branch May 17, 2023 13:51
@pierreprinetti pierreprinetti mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandre @coveralls @pierreprinetti