clouds: support clouds.yml in addition to clouds.yaml #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtopjian
requested changes
Jan 28, 2021
There was a problem hiding this comment.
@DSpeichert Thank you for submitting this - it's appreciated. I've left one comment with respect to the named return values. Please let me know if you have any questions or would like to discuss.
openstack/clientconfig/utils.go
Outdated
| // | ||
| // If found, the contents of the file is returned. | ||
| func FindAndReadCloudsYAML() (string, []byte, error) { | ||
| func FindAndReadCloudsYAML() (s string, b []byte, err error) { |
There was a problem hiding this comment.
nit: Can you revert this? I'm not opposed to named return values, but introducing this would break style consistency within the rest of the code.
While not clearly documented, the native openstacksdk package supports both extensions. This brings parity with the official Python SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not clearly documented, the native openstacksdk package supports both
extensions. This brings parity with the official Python SDK.