Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Add sandboxed iframe #5

Open
ajhager opened this issue Oct 31, 2014 · 3 comments
Open

Playground: Add sandboxed iframe #5

ajhager opened this issue Oct 31, 2014 · 3 comments
Assignees

Comments

@ajhager
Copy link

ajhager commented Oct 31, 2014

Replace 'generated code' pane with an iframe the program is injected into. This way, the user can experiment with dom manipulation without interfering with the appearance and functionality of the playground itself.

Also add fullscreen button that overlays the iframe on top of the playground with full width and height of the page.

@ajhager ajhager self-assigned this Oct 31, 2014
@dmitshur
Copy link
Member

dmitshur commented Nov 1, 2014

Also add fullscreen button that overlays the iframe on top of the playground with full width and height of the page.

What does this mean and what is it for?

@ajhager
Copy link
Author

ajhager commented Nov 1, 2014

They press run, and the consequences show up in the iframe. The user might then want to be able to see the iframe maximized a bit. So perhaps the button expands the iframe to 90% - 100%. They can then explore their demo in a more spacious and typical environment.

@dmitshur
Copy link
Member

dmitshur commented Nov 1, 2014

Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants