Travis: Update to Go 1.8. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tip. It will not work, because GopherJS requires the current version of Go.
dominikh
approved these changes
Jul 17, 2017
|
Oh, actually, while GopherJS requires current version of Go, gopherpen only uses GopherJS compiler when |
It should be fine, since GopherJS compiler is only used with dev build tag. It's not used during normal build.
dominikh
reviewed
Jul 17, 2017
| language: go | ||
| go: | ||
| - 1.8.x | ||
| - master |
There was a problem hiding this comment.
Does master mean the same thing as tip to Travis?
There was a problem hiding this comment.
Yes, it's the latest way of specifying it in Travis, that's why I changed it.
Reference: https://docs.travis-ci.com/user/languages/go/#Specifying-a-Go-version-to-use
|
PTAL. |
dominikh
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tip. It will not work, because GopherJS requires the current version of Go.