Improve behavior when unsupported HTTP method used. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.6: > The response MUST include an Allow header containing a list of valid > methods for the requested resource. Fix that by setting Allow header appropriately when returning Method Not Allowed status code. Use Method Not Allowed status code for /share endpoint. I don't recall why we went with Forbidden for /share unlike for /p/. Method Not Allowed seems more appropriate and consistent, so use it instead.
dmitshur
force-pushed
the
improve-MethodNotAllowed-use
branch
from
ffd6763 to
4935012
Compare
|
@shurcooL is making me say "LGTM". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.6:
Fix that by setting Allow header appropriately when returning Method Not Allowed status code.
Use Method Not Allowed status code for /share endpoint. I don't recall why we went with Forbidden for /share unlike for /p/. Method Not Allowed seems more appropriate and consistent, so use it instead.