Improve tests. #10
Merged
Improve tests. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The third party package does not make the code any shorter or easier to understand. Most people are more familiar with net/http. It makes sense to use it in this case. Remove code that serves sourcemaps from GOROOT and GOPATH. I could not verify it had any effect. Also, GOPATH variable may not be a valid path if it contains more than one GOPATH workspace, so it's incorrect code anyway. It can be re-added if needed.
|
👍 I'm not actually sure why I used Martini in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net/http. It makes sense to use it in this case.