Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing datetime format #165

Merged
merged 2 commits into from
May 8, 2017
Merged

changing datetime format #165

merged 2 commits into from
May 8, 2017

Conversation

fallcat
Copy link
Collaborator

@fallcat fallcat commented May 7, 2017

No description provided.

@eanyanwu
Copy link
Member

eanyanwu commented May 7, 2017

What was the problem with the signature page before?

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

The RA would not be able to enter signature as RA for his/her individual RCI

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

Actually, for a Common Area RCI, if the AC is the last one to sign, the page will still redirect back to dashboard after they sign as resident, and they have to go back to sign as AC.. which is not very smooth. I'm still thinking to change that.

@eanyanwu
Copy link
Member

eanyanwu commented May 7, 2017

I'm not sure what the problem is. I just reset my RCI then signed it fine:
capture d ecran 2017-05-07 a 19 23 49

For the common area signature thing, that's a good point. If you want to change it, could you do it in a new branch though?

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

I've already fixed the problem for individual RCI. Are you testing from my branch or the original one?

@eanyanwu
Copy link
Member

eanyanwu commented May 7, 2017

The original one, master

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

virtualbox_windows10_07_05_2017_19_32_49
But you are only able to sign as resident to confirm the damages, and sign the life and conduct statement. You can't sign as RA to confirm the damages.

@eanyanwu
Copy link
Member

eanyanwu commented May 7, 2017

If you are an RA, that signature updates for both the CheckinSigRes and CheckinSigRA columns. So you don't need to sign three times.
If you are a resident, it just just updates the CheckinSigRes column.

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

Alright

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

That does make sense. I'll change it back.

@fallcat
Copy link
Collaborator Author

fallcat commented May 7, 2017

fixed

@eanyanwu eanyanwu requested review from eanyanwu and removed request for eanyanwu May 8, 2017 00:01
Copy link
Member

@eanyanwu eanyanwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet! Two last things though:
~ When the person has already signed, you should probably remove the name attribute of the~ input field. If not, the signature will get resubmitted.
~ Don't forget to add the Life and conduct statement for the RA as well!~

Copy link
Member

@eanyanwu eanyanwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet! Two last things though:

@eanyanwu
Copy link
Member

eanyanwu commented May 8, 2017

Yikes, I messed up on GitHub comments. Ignore the previous attempts

Sweeet! Two last things though:

When the person has already signed, you should probably remove the name attribute of the input field. If not, the signature will get resubmitted.
Don't forget to add the Life and conduct statement for the RA as well!

@eanyanwu
Copy link
Member

eanyanwu commented May 8, 2017

Jk my issues were addressed. Looks great to me!

@eanyanwu eanyanwu merged commit 8163ee3 into master May 8, 2017
@eanyanwu eanyanwu deleted the datetime branch June 17, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants