-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing datetime format #165
Conversation
What was the problem with the signature page before? |
The RA would not be able to enter signature as RA for his/her individual RCI |
Actually, for a Common Area RCI, if the AC is the last one to sign, the page will still redirect back to dashboard after they sign as resident, and they have to go back to sign as AC.. which is not very smooth. I'm still thinking to change that. |
I've already fixed the problem for individual RCI. Are you testing from my branch or the original one? |
The original one, master |
If you are an RA, that signature updates for both the |
Alright |
That does make sense. I'll change it back. |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeet! Two last things though:
~ When the person has already signed, you should probably remove the name
attribute of the~ input field. If not, the signature will get resubmitted.
~ Don't forget to add the Life and conduct statement for the RA as well!~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeet! Two last things though:
Yikes, I messed up on GitHub comments. Ignore the previous attempts Sweeet! Two last things though: When the person has already signed, you should probably remove the name attribute of the input field. If not, the signature will get resubmitted. |
Jk my issues were addressed. Looks great to me! |
No description provided.