Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify rpm add file #247

Merged
merged 2 commits into from
Nov 9, 2020
Merged

refactor: simplify rpm add file #247

merged 2 commits into from
Nov 9, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 8, 2020

No description provided.

@caarlos0
refactor: simplify rpm add file
668e662 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented Nov 8, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/4vpekg6vf
✅ Preview: https://nfpm-git-ref.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2020
@caarlos0 caarlos0 added automerge enhancement New feature or request labels Nov 8, 2020
@codecov
Copy link

codecov bot commented Nov 8, 2020 •
edited
Loading

Codecov Report

Merging #247 (865f7eb) into master (8c19c6a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   66.73%   66.79%   +0.06%     
==========================================
  Files           9        9              
  Lines        1031     1027       -4     
==========================================
- Hits          688      686       -2     
+ Misses        206      205       -1     
+ Partials      137      136       -1
Impacted Files Coverage Δ
rpm/rpm.go 73.39% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c19c6a...865f7eb. Read the comment docs.

djgilcrease
djgilcrease approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview November 9, 2020 03:41 Inactive
@kodiakhq kodiakhq bot merged commit 2e41d95 into master Nov 9, 2020
@kodiakhq kodiakhq bot deleted the ref branch November 9, 2020 03:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

Assignees
No one assigned
Labels
automerge enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @djgilcrease