Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using directories as contents in archlinux packager #568

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

Elara6331
Copy link
Contributor

@Elara6331 Elara6331 commented Oct 27, 2022

This PR allows using directories in the contents when using the archlinux packager. It also adds acceptance tests for all the packagers so that no one misses this use case in the future.

Fixes #564

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2022
@Elara6331 Elara6331 marked this pull request as ready for review October 27, 2022 03:08
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #568 (4894ca6) into main (2f0c3d3) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   70.26%   70.25%   -0.01%     
==========================================
  Files          21       21              
  Lines        3087     3127      +40     
==========================================
+ Hits         2169     2197      +28     
- Misses        698      706       +8     
- Partials      220      224       +4     
Impacted Files Coverage Δ
arch/arch.go 74.44% <70.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit b4bd781 into goreleaser:main Oct 27, 2022
@caarlos0
Copy link
Member

noice, thanks @Arsen6331 !

@github-actions github-actions bot added this to the v2.21.0 milestone Oct 27, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Oct 27, 2022
@Elara6331 Elara6331 deleted the fix-archlinux-dirs branch October 28, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

archlinux packager does not support folders for configs
2 participants