Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hard fail on missing maintainer #672

Closed
wants to merge 1 commit into from
Closed

feat: hard fail on missing maintainer #672

wants to merge 1 commit into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 6, 2023

it has been deprecated for > 1 year, I think its time?

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 6, 2023
@caarlos0 caarlos0 requested a review from a team June 6, 2023 17:44
@caarlos0 caarlos0 self-assigned this Jun 6, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2023
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f82f4ed
Status: ✅  Deploy successful!
Preview URL: https://bbe50b0f.nfpm.pages.dev
Branch Preview URL: https://maintainer.nfpm.pages.dev

View logs

@erikgeiser
Copy link
Member

Yeah a year should be enough 👍

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #672 (f82f4ed) into main (af65ba8) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   75.81%   75.71%   -0.10%     
==========================================
  Files          14       14              
  Lines        2956     2957       +1     
==========================================
- Hits         2241     2239       -2     
- Misses        506      508       +2     
- Partials      209      210       +1     
Impacted Files Coverage Δ
nfpm.go 84.93% <ø> (ø)
deb/deb.go 70.96% <50.00%> (-0.56%) ⬇️

@caarlos0
Copy link
Member Author

anyone interested in this? I'm not working with ES anymore so I'm closing this, if anyone wants to pick it up, feel free to :)

@caarlos0 caarlos0 closed this Jun 13, 2023
@caarlos0 caarlos0 deleted the maintainer branch May 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants