feat: Add support for remote signing keys #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
When used as a library, `nfpm.PackageSignature.SignFn` can be set as an alternative to `KeyFile`. This allows arbitrary signing key implementations, like a remote signing server. Updates tailscale/tailscale#1882
caarlos0
approved these changes
Aug 2, 2023
|
@caarlos0 thanks! |
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 74.80% 75.02% +0.21%
==========================================
Files 10 10
Lines 2385 2406 +21
==========================================
+ Hits 1784 1805 +21
Misses 425 425
Partials 176 176
|
|
merged, thank you @awly (I love tailscale btw 🙏) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used as a library,
nfpm.PackageSignature.SignFncan be set as an alternative toKeyFile. This allows arbitrary signing key implementations, like a remote signing server.Updates tailscale/tailscale#1882