fix: Ensure reproducable Deb package #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Each time building exaclty from the same source, ensure exaclty the same size deb package is generated. Signed-off-by: keliramu <ramunas.keliuotis@nordsec.com>
keliramu
force-pushed
the
ensure-reproducable-deb
branch
from
ceea871
to
c4959c5
Compare
keliramu
commented
Dec 5, 2023
| @@ -391,14 +391,14 @@ func createFilesInsideDataTar(info *nfpm.Info, tw *tar.Writer) (md5buf bytes.Buf | |||
| Format: tar.FormatGNU, | |||
| Uname: file.FileInfo.Owner, | |||
| Gname: file.FileInfo.Group, | |||
| ModTime: file.FileInfo.MTime, | |||
| ModTime: time.Unix(0, 0), | |||
There was a problem hiding this comment.
Probably ModTime setting to zero should be controlled via some kind of flag or config option.
keliramu
commented
Dec 5, 2023
| "./md5sums": md5sums, | ||
| "./conffiles": conffiles(info), | ||
| // ensure predefined sort order of these items | ||
| filesToCreateNames := []string{ |
There was a problem hiding this comment.
Go map[string] does not ensure predefined sort order when iterated via for ... range ... and that is the cause of control.tar.gz is different size when executed on the same input.
2 tasks
|
gonna merge this and continue working on it, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time building exaclty from the same source,
ensure exaclty the same size deb package is generated.