Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for ipk packages #818

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: support for ipk packages #818

merged 1 commit into from
May 8, 2024

Conversation

schmidtw
Copy link
Contributor

Implements #507.

  • Adds ipk support for keywords used by OpenWRT and Yocto.
  • MD5sum is explicitly excluded due to insecurity.
  • SHA256Sum excluded due packages not being individually signed, instead, the feed of packages is checksummed and signed externally.
  • Adds code to nfpm package to automatically enumerate the supported packaging types where possible.

Implements goreleaser#507.

* Adds ipk support for keywords used by OpenWRT and Yocto.
* MD5sum is explicitly excluded due to insecurity.
* SHA256Sum excluded due packages not being individually signed,
  instead, the feed of packages is checksummed and signed externally.
* Adds code to nfpm package to automatically enumerate the supported
  packaging types where possible.
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 72.65%. Comparing base (409b516) to head (2210695).
Report is 4 commits behind head on main.

Files Patch % Lines
ipk/ipk.go 86.88% 13 Missing and 11 partials ⚠️
ipk/tar.go 58.49% 11 Missing and 11 partials ⚠️
nfpm.go 15.38% 10 Missing and 1 partial ⚠️
internal/cmd/package.go 0.00% 4 Missing ⚠️
internal/cmd/root.go 0.00% 2 Missing ⚠️
cmd/nfpm/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   72.19%   72.65%   +0.46%     
==========================================
  Files          20       22       +2     
  Lines        2237     2487     +250     
==========================================
+ Hits         1615     1807     +192     
- Misses        438      473      +35     
- Partials      184      207      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw
Copy link
Contributor Author

schmidtw commented May 2, 2024

@caarlos0 any feedback?

@caarlos0
Copy link
Member

caarlos0 commented May 3, 2024

sorry, haven't had the time to look into it yet... will probably review over the weekend.

at first glance, it does look good though!

also, thanks for the PR 🙏🏻

@caarlos0 caarlos0 merged commit bc5c3bd into goreleaser:main May 8, 2024
47 checks passed
@github-actions github-actions bot added this to the 2.36.0 milestone May 8, 2024
@caarlos0
Copy link
Member

caarlos0 commented May 8, 2024

it looks awesome, thanks!

and sorry for the delay reviewing it!

@caarlos0 caarlos0 modified the milestones: 2.36.0, 2.37.0 May 8, 2024
@abemedia abemedia mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants