Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hit Counter for Personal Filters #1353

Open
ayuanx opened this issue Feb 8, 2016 · 5 comments
Open

[Feature Request] Hit Counter for Personal Filters #1353

ayuanx opened this issue Feb 8, 2016 · 5 comments

Comments

@ayuanx
Copy link

ayuanx commented Feb 8, 2016

Is it possible to add a hit counter for each personal filter? (Public filter list without counter is fine.)
Since all webpages change frequently, without a filter hit counter, after several months, it is impossible to tell which ones are obsolete.

The hit counter would be a very effective way to discover and clean up outdated personal filters.

@gorhill gorhill closed this as completed Feb 8, 2016
@gorhill gorhill reopened this Feb 8, 2016
@gorhill gorhill removed the declined label Feb 8, 2016
@dhowe
Copy link
Contributor

dhowe commented May 11, 2016

This would indeed be useful

@Zungao
Copy link

Zungao commented Sep 25, 2016

Please consider this! I use ublock with my own filter list, no external lists, and this would be very useful (eventually with an on/off switch for performance reasons).

@Peuj
Copy link

Peuj commented Jan 4, 2017

For maintenance and so performance reasons hit counter could be really useful but NOT only for personal filters:

  • For personal filters to clean unused/obsoletes filters
  • For dynamic filtering rules to clean unused/obsoletes rules
  • For the 3rd-party filters, it would show how a 3rd-party filter is used and if it's worth loading it.

As written in the wiki "The more filter lists are selected, the higher the likelihood of web site breakage. The quality of the selected filter lists also affects the likelihood of web site breakage."

It's more a maintenance feature (a checkbox unchecked by default) which help the user to keep the filters, rules up to date.

@Zungao
Copy link

Zungao commented Jun 18, 2017

Ping!

Any news on this? Since you removed the declined label on February last year I has hoping you were considering the request, but I haven't found any development (pun intended) on the issue.

@gorhill
Copy link
Owner

gorhill commented Oct 15, 2017

Really a duplicate of #983.

gorhill added a commit that referenced this issue May 24, 2019
Related issue:
- #983
- #1353

The current implementation reports statistics for all
static filters, and the presentation/featureset is
intentionally minimal: *Do not open issues about this.*
It's still a work in progress and it will be worked on
slowly and thoughtfully over time and as time allows.

Pausing the logger will not pause the collation of
filter hit statistics, thus it is possible to lower
the logger overhead by pausing logger output without
losing filter hit collation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants