Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup detection mistake #3112

Closed
Matthewus opened this issue Oct 9, 2017 · 7 comments
Closed

Popup detection mistake #3112

Matthewus opened this issue Oct 9, 2017 · 7 comments

Comments

@Matthewus
Copy link

Filter issues MUST NOT be reported here. Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

Tabs closing when opening multiple links on ikshow.net while popup blocking is enabled via popup menu.

One or more specific URLs where the issue occurs

http://ikshow.net/

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

Go to ikshow.net, open multiple links quickly. Quickly is important because if i open the next link after the previous is completly loaded everything is fine.

Your settings

Default settings, only the popups disabled on http://ikshow.net/

  • OS/version: Windows 10 64 bit
  • Browser/version: Firefox 56 64 bit
  • uBlock Origin version: 1.14.14
Your filter lists

Default

Your custom filters (if any)

None

@gorhill
Copy link
Owner

gorhill commented Oct 9, 2017

You're going to have to come up with much better repro steps, and analysis of the logger. Read carefully 1st paragraph in CONTRIBUTING.

@gorhill gorhill closed this as completed Oct 9, 2017
gorhill added a commit to uBlockOrigin/uAssets that referenced this issue Oct 9, 2017
@gorhill
Copy link
Owner

gorhill commented Oct 9, 2017

That site is afflicted by popunders, that I could reproduce. Fixed with a filter in "uBlock filters".

@Matthewus
Copy link
Author

Thanks, the filter works great.
Here is a video of what happened before, when i enabled popup blocking:
https://drive.google.com/open?id=0B4zNZvqz2Gl5bE4ySFZCUGVQXzQ

@gorhill
Copy link
Owner

gorhill commented Oct 9, 2017

So you are middle-clicking? I was trying to reproduce with left-clicking. With middle-clicking, I can reproduce.

@Matthewus
Copy link
Author

Yes middle or CTRL+left clicking. Sorry that i left out an important detail, i thought i wrote it.

@gorhill
Copy link
Owner

gorhill commented Oct 9, 2017

Dev memo: I suspect the issue is caused by the use of one global "clicked URL" used for all new tabs being created. There should be one "clicked URL" associated with each new tab at creation time. Issue also occurs with Chromium.

gorhill added a commit that referenced this issue Oct 13, 2017
@gorhill
Copy link
Owner

gorhill commented Oct 13, 2017

Fixed with 7713597.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants