Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Redirection to neutered scriptlet broken by forbidden redirection to data: urls #3474

Closed
gorhill opened this issue Jan 31, 2018 · 3 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2018

Originally filed at:
uBlockOrigin/uAssets#1370

Corresponding bugzilla entry:
https://bugzilla.mozilla.org/show_bug.cgi?id=1434357

Test case (from original issue):
http://kissasian.ch/Drama/Age-of-Youth-2/Episode-1?id=34574&s=beta&pfail=1

@jspenguin2017
Copy link
Contributor

How about using request filtering to replace the response data with the neutralized version? One request will hit the script server, but that's better than breaking the page and having to disable all filtering.

I have yet to study how filtering engine is implemented, but from my current understanding, some refactoring might be required, as the request needs to be allowed then filtered later.

@ff2000
Copy link

ff2000 commented Feb 2, 2018

I know this is about nightly... But since blocking is basically not working anymore since firefox update from 58.0 to 58.0.1 I wanted to ask if this is caused by the same issue or if I should open a new one.

@gorhill
Copy link
Owner Author

gorhill commented Feb 2, 2018

blocking is basically not working anymore since firefox update from 58.0 to 58.0.1

I know of no such issue. Please investigate more on your side before opening a new issue -- if you open a new issue without being able to make the case there is an issue with uBO itself, I will close as invalid.

@gorhill gorhill changed the title [Nightly] Neutered scriptlet injection broken by forbidden redirection to data: urls [Nightly] Redirection to neutered scriptlet broken by forbidden redirection to data: urls Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants