ublock sometimes does not load site completely #3526
Comments
|
You failed to provide URLs where you see the issue (read carefully CONTRIBUTING). |
|
Labelling "available" = somebody who can reproduce will have to investigate -- it's unactionable otherwise. |
|
Ok, I've reproduced the case of "mixup of the webpage and the sourcecode" at
So now I have something I can investigate. |
|
It's extremely difficult to reproduce -- but I did reproduce, though sometimes I reload the page 100+ times before I can see the issue happening. I am going to need help in finding better repro steps. My guess is that it is related to response data filtering, but a specific code path: when only scriptlets need to be injected, which is the case on I try to stick to a "small" page, I looked at the DOM when it finally happened again, and it is as if a chunk of response data was missing. I did find another unrelated issue with that part of the code in uBO, which was a missing cleanup after injecting the scriptlet, but fixing this does not resolve the issue, I could make it happen again. It happens so rarely at this point that it's impossible to narrow the cause -- for all I know it could maybe also happen without uBO or with another blocker, it could be the server, it could be Firefox, etc. An observation, but this would need to be confirmed, which is difficult given how rare the issue occurs on my side: it seems when the issue occurs, Firefox starts to severely leak memory, I see a lot of strings in |
|
Cool. The Intend of coming back here was only to tell you that I can fully understand, that you can't give me any help due to the fact that I can't provide an exact way to reproduce my problem. I only wanted to make sure that I have reported the Issue because I have worked since a week to provide a reproducible way and, after eleminating all other causes, are now sure that it's in fact a problem with udblock. I love my firefox as well as ublock so much and can't image to renounce any of them. Second: I am now trying the ublock version from december 17 - 1.14.22. As you now know that the problem does not happen very often, I will see in the next 24 hours if it happens again. I am now using the old version since about 5 hours and my feeling is that the problem should have occurede since. So that's a good sign beginning to isolate the problem. If I can provide you with any other informations you need, please let me know. I could - if you wish - go back to the -presumed- faulty version of ublock to give you other websites where the problem occures. And don'd forget that this problem occued on several other websites also. I remember in particular chip.de (was today) for example but I have had this problem on many pages. |
|
Can confirm this, and yeah it's not only rare it's quite weird like the elements are being rendered out of order or something. No doubt a browser problem but I certainly have NFI where. @Juschi1 do you run into things like seeing images render for half a second then disappear? uM 1.1.21.3 |
|
Well, if this is indeed the same phenomenon on Chromium we'll have a new problem here. The suspicion so far has been that this is related to the response data filtering, right? That would be Firefox only, at the moment.
BTW, what version is this? Current stable is at 64.0.3282.167/168.. |
|
Chrome pushed forward with some questionable things. It's still the latest in repo though. |
It's not. I'm on Chromium 66 and have used 64 in the past few months, nothing of this sort ever happened. |
|
Removed my original reply as I misread what you said. Still have no idea why you gave a thumbs down but whatever. |
|
What I need help with at this point is with narrowing. If this is a timing issue, some of you may have better chance at reproducing the issue, and thus are better placed to help narrowing. At this point, my best guess is a very specific code path used when all the following conditions are met
To narrow should be simple enough:
Narrowing:
|
|
Something I was playing with that may or may not be related but exhibits similar behavior is simply blocking images. If you block all requests to raw.githubusercontent.com on https://github.com/lenosisnickerboa/csgosl/wiki for example, on first load you'll see the placeholder. If you then allow images the first reload will not show anything. It takes one or more refresh attempts. You'll have to wait a bit between retries or force a cache flush (after a successful load). Does that jive with anything here or is it completely different? I have had entire pages load as if it were blank as per above, wondering if these are related. Update: was writing this before your reply above gorhill |
|
probably related: When an inject filter is used the page becomes blank on firefox disabling the existing filter and adding other 1
|
No, I looked at it. The issue is more likely that with Firefox the scriptlet is guaranteed to be injected at the top of the document, which is not the case for Chromium. If you The issue here is clear when it happens: Firefox is using a buffer with bad content in it. |
|
@mapx- Hmm, actually let me investigate more, not sure what the issue is. The page does not declare a |
|
I have now used ublock 1.14.22 since 2 days and the problem did not occur. In the newest version the problem did occur about every few hours. My feeling is that the 1.14.22 is not affected. |
|
Try 1.15.11b0 on AMO, this version no longer use stream filtering to inject scriptlets. My best guess at this point is that there is an issue somewhere in Firefox's StreamFilter API. |
|
on AMO I only see 1.15.10 |
|
He meant the BETA version from here - https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/beta |
|
I have the same problems in the beta. For example: http://fs1.directupload.net/images/180223/u9fowbpt.png on went now back again to 1.14.22 |
Yes, 1.15.11b0 is a dud -- I made a stupid mistake in the code in my haste to push a beta version before the Feb 22 deadline (the date at which AMO no longer allow beta versions to be uploaded). |
|
@Juschi1 You can use 1.15.10, this version does not rely on stream filtering for scriptlets injection. I don't know why I told you to use the beta version when 1.15.10 should work fine. |
[Unrelated issue collapsed to minimize noise: filtering issue, report to uAssets, feel free to delete your comment -- gorhill]i had the same problem **every single time** on loading the page of [RARBG](https://rarbg.to/). you could see the page being loaded for a millisecond or so and then most of it was hidden, even though i allowed every ressource in uBlock. disabling uBlock helped, but i just found out that simply deactivating the "cosmetic filter" also solves my issue.
luckily this filter is only disabled on that page and not globally. well i guess luckily, i don't really know what it does. |
|
Closing as no longer an issue, I won't bring back injection scriptlets into the response data. |
Describe the issue
I have the following issue: Since two weeks or so, I have the problem, that sometimes firefox loads webpages not completely, when ublock active. It's about every 30. loading. Then, sometimes, elements of the webpage are missing or the webpage fails to load completely (white page) oder I see a mixup of the webpage and the sourcecode. I use firefox with no other add-ons installed with a fresh profile. If I deactivate ublock, the problem is gone. I have reinstalled ublock several times, resetted firefox and used a new profile. With "Adblock Plus" I don't have this issue but i want to use ublock.
One or more specific URLs where the issue occurs
It can happen on every webpage.
Screenshot in which the issue can be seen
http://fs1.directupload.net/images/180219/a4kelr3z.png
http://fs1.directupload.net/images/180219/l5cuxsnh.png
Steps for anyone to reproduce the issue
Your settings
Your filter lists
Everything default.
Your custom filters (if any)
The text was updated successfully, but these errors were encountered: