Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Option to disable "filter comments" #93

Closed
hejops opened this issue Apr 19, 2015 · 1 comment
Closed

[Suggestion] Option to disable "filter comments" #93

hejops opened this issue Apr 19, 2015 · 1 comment

Comments

@hejops
Copy link

hejops commented Apr 19, 2015

Personally I find the comment that is added together with a filter (i.e. ! (website)) unnecessary and cluttery. However I understand some users may find it useful, if not important. Could an option to disable the adding of such comments be feasible to implement?
@hejops hejops changed the title [Suggestion] Option to disable "add filter comments" [Suggestion] Option to disable "filter comments" Apr 19, 2015
@gorhill
Copy link
Owner

gorhill commented Apr 20, 2015

Thought this one through, and I will pass for two reasons (which I won't argue further):

  1. In the long run, this information is to actually reduce cluttering, by giving the information to the user about how likely a filter may be obsolete. With the date/URL, a user can easily go back check whether a filter is still needed.
  2. I My approach is to be extremely conservative with adding yet-another-user-setting: these can't be really removed once they are added. User settings should be a last resort measure for when something cannot be dealt with otherwise -- and in the current case I don't agree that the date/URL information is a liability, it's too help to keep track why the filter was created in the first place.

@gorhill gorhill closed this as completed Apr 20, 2015
@uBlock-user uBlock-user mentioned this issue Jan 8, 2019
Closed
8 tasks
gorhill added a commit that referenced this issue Jan 8, 2019
@gorhill
Add ability to control auto-commenting at filter creation time
64bea27 
Related issues:
- uBlockOrigin/uBlock-issues#372
- #93

A new advanced settings has been added: `autoCommentFilterTemplate`.

Default value is `{{date}} {{origin}}`.

Placeholders are identified by `{{...}}`. There are currently
only three placeholders supported:

- `{{date}}`: will be replaced with current date
- `{{time}}`: will be replaced with current time
- `{{origin}}`: will be replaced with site information on which
  the filter(s) was created

If no placeholder is found in `autoCommentFilterTemplate`, this
will disable auto-commenting. So one can use `-` to disable
auto-commenting.

Additionally, if auto-commenting is enabled, uBO will not emit a
comment if an emitted comment would be a duplicate of the last
one found in the user filter list.
hawkeye116477 added a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Aug 11, 2020
@hawkeye116477 @gorhill
Add ability to control auto-commenting at filter creation time
149e30f 
Related issues:
- uBlockOrigin/uBlock-issues#372
-gorhill/uBlock#93

A new advanced settings has been added: `autoCommentFilterTemplate`.

Default value is `{{date}} {{origin}}`.

Placeholders are identified by `{{...}}`. There are currently
only three placeholders supported:

- `{{date}}`: will be replaced with current date
- `{{time}}`: will be replaced with current time
- `{{origin}}`: will be replaced with site information on which
  the filter(s) was created

If no placeholder is found in `autoCommentFilterTemplate`, this
will disable auto-commenting. So one can use `-` to disable
auto-commenting.

Additionally, if auto-commenting is enabled, uBO will not emit a
comment if an emitted comment would be a duplicate of the last
one found in the user filter list.

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@garry-ut99 garry-ut99 mentioned this issue Dec 14, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @hejops