Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rss comment #33

Closed
metal3d opened this issue Mar 29, 2016 · 5 comments
Closed

Rss comment #33

metal3d opened this issue Mar 29, 2016 · 5 comments

Comments

@metal3d
Copy link

metal3d commented Mar 29, 2016

Hi, first: congrats ! I'm using Gorilla as base for my own framework (https://github.com/kwiscale) and I'm using gorilla/feeds in my web blog (https://www.metal3d.org/feed/rss and https://www.metal3d.org/feed/atom). I wanted to add "comments" from my blogpost in RSS items, I see that RssItem struct has Comments property:
https://github.com/gorilla/feeds/blob/master/rss.go#L69

But I really don't see how to use them. If there is a good practice or if this field is a work in progress.

Can you tell us more ?

Thanks !

@elithrar
Copy link
Contributor

Comments should typically contain a link to your comments page, not the
comments themselves:
http://cyber.law.harvard.edu/rss/rss.html#ltcommentsgtSubelementOfLtitemgt (RSS
spec)

On Tue, Mar 29, 2016 at 6:28 AM Patrice Ferlet notifications@github.com
wrote:

Hi, first: congrats ! I'm using Gorilla as base for my own framework (
https://github.com/kwiscale) and I'm using gorilla/feeds in my web blog (
https://www.metal3d.org/feed/rss and https://www.metal3d.org/feed/atom).
I wanted to add "comments" from my blogpost in RSS items, I see that
RssItem struct has Comments property:
https://github.com/gorilla/feeds/blob/master/rss.go#L69

But I really don't see how to use them. If there is a good practice or if
this field is a work in progress.

Can you tell us more ?

Thanks !


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33

@metal3d
Copy link
Author

metal3d commented Mar 29, 2016

That's what I found searching in specs. I've just understood that feeds that I read uses a extended atom specification. Eg: http://linuxfr.org/news.atom

There's this kind of tag:

<wfw:commentRss>http://linuxfr.org/nodes/108491/comments.atom</wfw:commentRss>

That's why liferea RSS reader can display comments. So I will find a way to adapt my feed processing.

Thanks for you help :)

@elithrar
Copy link
Contributor

See my other comment RE: namespaces

On Tue, Mar 29, 2016 at 7:42 AM Patrice Ferlet notifications@github.com
wrote:

For more information:

https://developer.mozilla.org/en-US/docs/Web/RSS/Article/Why_Well-Formed_Web_RSS_Module_is_Popular_-_Syndicating_Your_Comments


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#33 (comment)

@metal3d
Copy link
Author

metal3d commented Mar 30, 2016

I'm closing this report because it's a duplication of #25

@metal3d metal3d closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants