make UnmarshalText take precedence as a converter

[jlburkhead]

This is related to this issue. Happy to add tests or make any changes if you agree this makes sense

[elithrar]

@kisielk ?

[kisielk]

This seems reasonable to me. But I think we need tests for the different orders of precedence of unmarshal methods.

[jlburkhead]

realizing decoding slices is dealt with separately (https://github.com/gorilla/schema/blob/master/decoder.go#L148) and will require additional changes. example run using this branch:

package main

import (
    "errors"
    "fmt"

    "github.com/gorilla/schema"
)

type Foo string

func (f *Foo) UnmarshalText(text []byte) error {
    if string(text) != "foo" {
        return errors.New("not foo")
    }
    *f = Foo(text)
    return nil
}

type Stuff struct {
    Value Foo
}

type SliceStuff struct {
    Values []Foo
}

func main() {
    stuff := new(Stuff)
    values := map[string][]string{
        "Value": {"abc"},
    }

    decoder := schema.NewDecoder()
    err := decoder.Decode(stuff, values)

    fmt.Println(err)   // schema: error converting value for "Value". Details: not foo
    fmt.Println(stuff) // &{}

    sliceStuff := new(SliceStuff)
    values = map[string][]string{
        "Values": {"abc", "def"},
    }

    err = decoder.Decode(sliceStuff, values)
    fmt.Println(err)        // <nil>
    fmt.Println(sliceStuff) // &{[abc def]}
}

[jlburkhead]

Here's another edge case which happens on master and is not fixed by this pr

package main

import (
    "errors"
    "fmt"

    "github.com/gorilla/schema"
)

type Foo struct {
    Data string
}

func (f *Foo) UnmarshalText(bytes []byte) error {
    return errors.New("always return an error")
}

type Stuff struct {
    Value Foo
}

func main() {
    stuff := new(Stuff)
    values := map[string][]string{
        "Value": {""},
    }
    decoder := schema.NewDecoder()
    err := decoder.Decode(stuff, values)
    if err != nil {
        panic(err)
    }

    fmt.Printf("%#v\n", stuff) // &main.Stuff{Value:main.Foo{Data:""}}
}

[jlburkhead]

added some wip on using encoding.TextUnmarshaler on slices and tests

[elithrar]

Let me know once you are happy for me to review.
On Tue, Sep 20, 2016 at 3:59 PM Jake Burkhead notifications@github.com
wrote:

added some wip on using encoding.TextUnmarshaler on slices and tests

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#58 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABIcMLBcRXpI7eVUVEvPteOcXslO1j4ks5qsGVCgaJpZM4H8_qx
.

[jlburkhead]

@elithrar ive worked on this as much as i want/have time to. up to you if you consider it finished or if you want to make any changes to it. i would have liked to have one single method that handles the precedence for converting values. all of the existing tests pass and i added new tests

[tniswong]

This PR fixes my issue. Can we revisit what it takes to get this merged?

[kisielk]

@tniswong #64 does it, but as I mentioned there, there are no tests...